[PART1] Add pip_requirements and extra_pip_requirements to all flavors except xgboost flavor
#4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
rn/feature
dbczumar
reviewed
Jul 19, 2021
dbczumar
changed the title
pip_requirements and extra_pip_requirements to all flavors except xgboost flavor.pip_requirements and extra_pip_requirements to all flavors except xgboost flavor.
harupy
changed the title
pip_requirements and extra_pip_requirements to all flavors except xgboost flavor.pip_requirements and extra_pip_requirements to all flavors except xgboost flavor
harupy
changed the title
pip_requirements and extra_pip_requirements to all flavors except xgboost flavorpip_requirements and extra_pip_requirements to all flavors except xgboost flavor
harupy
changed the title
pip_requirements and extra_pip_requirements to all flavors except xgboost flavorpip_requirements and extra_pip_requirements to all flavors except xgboost flavor
|
@dbczumar Can we split this PR into two? PR1 updates:
PR2 updates:
|
harupy
commented
Jul 22, 2021
Comment on lines
+570
to
+577
| merged_conda_deps = _union_lists(shap_conda_deps, model_conda_deps) | ||
| merged_pip_deps = _union_lists(shap_pip_deps, model_pip_deps) |
There was a problem hiding this comment.
Used _union_lists here to preserve the item order and make the outcome deterministic & predictable.
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
harupy
changed the title
pip_requirements and extra_pip_requirements to all flavors except xgboost flavorpip_requirements and extra_pip_requirements to all flavors except xgboost flavor
Merged
35 tasks
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
dbczumar
reviewed
Jul 27, 2021
dbczumar
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
LGTM once MLeap has been reverted (#4577 (comment)). Thanks @harupy !
Signed-off-by: harupy <hkawamura0130@gmail.com>
|
@dbczumar Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy 17039389+harupy@users.noreply.github.com
What changes are proposed in this pull request?
Add
pip_requirementsandextra_pip_requirementsto the following flavors:How is this patch tested?
Unit tests
Release Notes
Is this a user-facing change?
log_modelandsave_modelsupportpip_requirementsandadditional_pip_requirementsfor directly specifying pip requirements of the model.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, JavaScript, plottingarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes