Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/artifact/mlflow: utilize netloc over host:port #5385

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

mert-kirpici
Copy link
Contributor

What changes are proposed in this pull request?

According to the urllib module documentation[1] and
RFC 1808 Section 2.1[2], the general structure of a URL is:

scheme://netloc/path;parameters?query#fragment

Utilizing netloc over hostname:port not only simplifies the
implementation but also allows authentication info to be
passed in the URL, i.e:

https://username:password@trackingserver.ai/

[1] https://docs.python.org/3/library/urllib.parse.html
[2] https://datatracker.ietf.org/doc/html/rfc1808.html#section-2.1

Signed-off-by: Mert Kırpıcı smertk@gmail.com

How is this patch tested?

Manually for now, but I am planning to add unit tests in a short while.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

URLs of the form http://user:pass@example.com/ used to work for the tracking server but not for artifact serving. This is fixed now.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

According to the urllib module documentation[1] and
RFC 1808 Section 2.1[2], the general structure of a URL is:

    scheme://netloc/path;parameters?query#fragment

Utilizing netloc over hostname:port not only simplifies the
implementation but also allows authentication info to be
passed in the URL, i.e:

    https://username:password@trackingserver.ai/

[1] https://docs.python.org/3/library/urllib.parse.html
[2] https://datatracker.ietf.org/doc/html/rfc1808.html#section-2.1

Signed-off-by: Mert Kırpıcı <smertk@gmail.com>
@github-actions github-actions bot added area/artifacts Artifact stores and artifact logging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Feb 16, 2022
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mert-kirpici LGTM - thanks so much for this fix! Happy to merge once lint issues have been resolved. Please let me know if you need assistance with this.

@harupy
Copy link
Member

harupy commented Feb 17, 2022

autoformat

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
@dbczumar
Copy link
Collaborator

autoformat

Forgot about this - awesome stuff!

@dbczumar
Copy link
Collaborator

Merging. Thanks again, @mert-kirpici !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Artifact stores and artifact logging rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants