-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: func _parse_mlflow_gcs_vars #5483
Merged
dbczumar
merged 6 commits into
mlflow:master
from
sebastian-montero:fix/func_parse_mlflow_gcs_vars
Mar 16, 2022
Merged
fix: func _parse_mlflow_gcs_vars #5483
dbczumar
merged 6 commits into
mlflow:master
from
sebastian-montero:fix/func_parse_mlflow_gcs_vars
Mar 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
dbczumar
reviewed
Mar 16, 2022
@sebastian-montero Thank you for filing this! LGTM once https://github.com/mlflow/mlflow/pull/5483/files#r827575875 is addressed! |
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
dbczumar
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @sebastian-montero !
Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
erensahin
pushed a commit
to erensahin/mlflow
that referenced
this pull request
Apr 11, 2022
* fix: func _parse_mlflow_gcs_vars Signed-off-by: sebsatian-montero <smonteroparis@icloud.com> * tests for _parse_mlflow_gcs_vars func Signed-off-by: sebsatian-montero <smonteroparis@icloud.com> * updated docs Signed-off-by: sebsatian-montero <smonteroparis@icloud.com> * removed _parse_mlflow_gcs_vars func Signed-off-by: sebsatian-montero <smonteroparis@icloud.com> * removed _parse_mlflow_gcs_vars test Signed-off-by: sebsatian-montero <smonteroparis@icloud.com> * Autoformat: https://github.com/mlflow/mlflow/actions/runs/1995463770 Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com> Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/artifacts
Artifact stores and artifact logging
rn/bug-fix
Mention under Bug Fixes in Changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sebsatian-montero smonteroparis@icloud.com
What changes are proposed in this pull request?
I am adding the function
_parse_mlflow_gcs_vars
that will better parse the new GCS MLFlow ENV variables. This will allow the engineer to use-1
as an input in order to set indefinite timeouts when using the underlying GS client to log artifacts.This PR is associated with this Issue
How is this patch tested?
Added parametrised tests to run every env var case.
Does this PR change the documentation?
ci/circleci: build_doc
check. If it's successful, proceed to thenext step, otherwise fix it.
Details
on the right to open the job page of CircleCI.Artifacts
tab.docs/build/html/index.html
.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes