Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: func _parse_mlflow_gcs_vars #5483

Merged
merged 6 commits into from
Mar 16, 2022
Merged

fix: func _parse_mlflow_gcs_vars #5483

merged 6 commits into from
Mar 16, 2022

Conversation

sebastian-montero
Copy link
Contributor

@sebastian-montero sebastian-montero commented Mar 11, 2022

Signed-off-by: sebsatian-montero smonteroparis@icloud.com

What changes are proposed in this pull request?

I am adding the function _parse_mlflow_gcs_vars that will better parse the new GCS MLFlow ENV variables. This will allow the engineer to use -1 as an input in order to set indefinite timeouts when using the underlying GS client to log artifacts.

This PR is associated with this Issue

How is this patch tested?

Added parametrised tests to run every env var case.

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
@github-actions github-actions bot added area/artifacts Artifact stores and artifact logging rn/bug-fix Mention under Bug Fixes in Changelogs. labels Mar 11, 2022
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
@dbczumar
Copy link
Collaborator

@sebastian-montero Thank you for filing this! LGTM once https://github.com/mlflow/mlflow/pull/5483/files#r827575875 is addressed!

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sebastian-montero !

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
@dbczumar dbczumar merged commit b336e74 into mlflow:master Mar 16, 2022
@sebastian-montero sebastian-montero deleted the fix/func_parse_mlflow_gcs_vars branch March 16, 2022 23:29
erensahin pushed a commit to erensahin/mlflow that referenced this pull request Apr 11, 2022
* fix: func _parse_mlflow_gcs_vars

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>

* tests for _parse_mlflow_gcs_vars func

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>

* updated docs

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>

* removed _parse_mlflow_gcs_vars func

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>

* removed _parse_mlflow_gcs_vars test

Signed-off-by: sebsatian-montero <smonteroparis@icloud.com>

* Autoformat: https://github.com/mlflow/mlflow/actions/runs/1995463770

Signed-off-by: mlflow-automation <mlflow-automation@users.noreply.github.com>

Co-authored-by: mlflow-automation <mlflow-automation@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Artifact stores and artifact logging rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants