Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] go client support #5484

Closed
wants to merge 4 commits into from
Closed

[draft] go client support #5484

wants to merge 4 commits into from

Conversation

nicolai86
Copy link

What changes are proposed in this pull request?

Implement go SDK support as requested in #1792

How is this patch tested?

TODO, I need to use the generated code in my code

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

@github-actions github-actions bot added the language/new Proposals for new client languages label Mar 12, 2022
@github-actions
Copy link

@nicolai86 Thanks for the contribution! The DCO check failed. Please sign off your commits by following the instructions here: https://github.com/mlflow/mlflow/runs/5519254428. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.rst#sign-your-work for more details.

@dbczumar
Copy link
Collaborator

@nicolai86 Thank you so much for developing an MLflow client for Go. At this time, the MLflow maintainers don't have a lot of expertise with maintaining and releasing Go libraries. Given that, would you be willing to implement / maintain the Go client as a standalone repository / package? Once the Go client has been developed / released, we'd be very excited to include a link to it in the MLflow docs. We're also happy to help out with manual QA :).

@nicolai86
Copy link
Author

I can do that for sure @dbczumar . Just to link things together, I started because of databricks/terraform-provider-databricks#1153. I'll pull this into a standalone repo and link it here once it exists.

@dbczumar
Copy link
Collaborator

I can do that for sure @dbczumar . Just to link things together, I started because of databrickslabs/terraform-provider-databricks#1153. I'll pull this into a standalone repo and link it here once it exists.

Awesome! Thanks so much, @nicolai86 !

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/new Proposals for new client languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants