Load user defined css after the main template css #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable customization of the main material design theme (for example to support RTL). The custom css should be loaded after the main theme's css.
szha
approved these changes
Jan 5, 2020
|
Has this been tested? Is there any way to ensure this doesn't break the existing functionality? |
|
@ChaiBapchya I tested locally and it works fine. I could set up, by tomorrow, a sample book on github pages that uses this version to see if everything works fine. |
|
Sure that will be awesome! Thanks! |
|
Sorry I didn't have time earlier to setup a demo. Here is a link to a demo using this branch to display RTL text |
|
Looks good to me! Few pages aren't translated yet i guess [for e.g. https://mohamed-ali.github.io/d2l-ar-demo/chapter_introduction/index.html#id9] but I'm guessing this being a sample demo we don't need full coverage. |
|
@mli good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable customization of the main material design theme's css (for example to support RTL: example discussion d2l-ai/d2l-en#670 (comment) ). The custom css should be loaded after the main theme's css.