Responsive Table #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to change `.m-table` back to `.browse-table` to help prevent styling issues once the Design System's `.m-table` class has been published.
jonearley
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Responsive styles have been added to the
tablecontaining browse results.This pull request resolves
Success Criteria > 1of SEARCH-1524.Anything else?
.m-tableThe Design System's
.m-tablestyles have not yet been pushed to https://unpkg.com/@umich-lib/web@1.2.1/umich-lib.css, so interim styles have been added.Match Notice
The
result.match_notice?row and fields have been restructured for styling and to reduce repeated code. The notice does not show up for me, even when viewing onmain, so I wasn't not able to fully test.Testing