Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max.concurrent.jobs for array jobs #163

Merged
merged 3 commits into from
Nov 29, 2017
Merged

max.concurrent.jobs for array jobs #163

merged 3 commits into from
Nov 29, 2017

Conversation

mnwright
Copy link
Contributor

If chunks.as.arrayjobs = TRUE and max.concurrent.jobs is used, it should be based on jobs not chunks.

Do we need a switch for chunks.as.arrayjobs = FALSE?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.429% when pulling 403e7a5 on mnwright:master into 0a59699 on mllg:master.

@mllg
Copy link
Owner

mllg commented Nov 29, 2017

Yes, there must be a switch for chunks.as.arrayjobs. I've pushed a fix for this. Can you confirm that this works for you?

@mnwright
Copy link
Contributor Author

Almost. * has higher precedence than !.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 93.945% when pulling bea76bb on mnwright:master into e46ad5f on mllg:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 93.945% when pulling bea76bb on mnwright:master into e46ad5f on mllg:master.

@mllg
Copy link
Owner

mllg commented Nov 29, 2017

Ouch, right. Thanks. That was the precedence of C 😢

@mllg mllg merged commit 2518854 into mllg:master Nov 29, 2017
@mnwright
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants