Slurm testing on Travis, update SLURM templates #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my fork/branch passes travis with 1 new NOTE about MPI that I was unsure of how to fix, https://travis-ci.org/tdhock/batchtools/jobs/622901681#L1033 |
|
you may consider adding a test/shQuote for the --name parameter in the slurm templates, which also causes problems if there are spaces. More generally it would be easier for the user to understand how to fix the problem if batchtools could detect these situations and give an informative error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mllg this PR was motivated by an application in which I am using batchtools with SLURM on some data stored in a path that has some unusual characters (spaces, parentheses).
It provides a fix for the slurm templates, by using
shQuoteon the log file path.It also provides test cases in test_slurm.R which use a local 1-node slurm cluster running on travis CI. (I updated the travis config file so that slurm is installed and configured)