New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templated Optimize() #113
Closed
Closed
Templated Optimize() #113
Changes from 37 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
e7c8515
Intermediate attempts.
rcurtin a8a00fd
Adapt some of the problem functions.
rcurtin cf13217
Allow L-BFGS to have different objective and gradient types.
rcurtin 00f1b40
Re-add different L-BFGS tests.
rcurtin a6b7f8c
Make lines fit a little bit better.
rcurtin d11940c
Add MatType and GradType to decomposable functions.
rcurtin 00e1dc3
Fix static checks to work with MatType/GradType.
rcurtin bb2d368
Actually these checks are not working right yet.
rcurtin 4e7e65a
Fix incorrect type.
rcurtin fdb42c9
Templatize SGDTestFunction.
rcurtin a1dd582
Adapt SGD to have templated MatType and GradType. Works.
rcurtin fb076d6
Add utility Any class.
rcurtin fcafc11
Adapt AdaDelta and AdaGrad and associated test problems.
rcurtin 261f71d
Update BigBatchSGD, Eve, FTML, Padam, and part of IQN.
rcurtin 3f4ee7a
Refactor nearly all optimizers.
rcurtin 57b1507
Add and update AugLagrangian and LRSDP tests.
rcurtin 6e6bece
Fix failing compilation and tests.
rcurtin e6b7bbc
Uncomment FunctionType checks.
rcurtin ae269d8
Add FTML test.
rcurtin 9cc1d24
Add checks for allowed MatTypes, etc.
rcurtin 9a4f01c
Adapt optimizers to use new checks.
rcurtin 31b6551
Add FTML test.
rcurtin 44a51bb
Update SDP tests.
rcurtin 3c2acbb
Update documentation where needed.
rcurtin cd2f801
Re-add and adapt FunctionTest.
rcurtin 71acbe4
Merge remote-tracking branch 'origin/master' into templated_optimize
rcurtin 743ea3a
Adapt SPSA.
rcurtin 03ac6d9
Merge remote-tracking branch 'origin/master' into templated_optimize
rcurtin 98e2714
Adapt AdaptiveStepsize to use a Policy to store MatTypes.
rcurtin 3c3bdd4
Disable tests that will fail when we have a too-old Armadillo version.
rcurtin 39c965f
Fix notes from Conrad's review.
rcurtin d7cb084
Fix documentation: also document new template parameters.
rcurtin 1881760
Use parent members directly.
rcurtin 70f32d2
Adapt DE optimizer (must have missed it).
rcurtin 381eff1
Update deprecated definition to match Armadillo.
rcurtin 92e2417
Merge remote-tracking branch 'origin/master' into templated_optimize
rcurtin 1a0b628
Update QHAdam and QHSGD.
rcurtin 09db596
Merge remote-tracking branch 'origin/master' into templated_optimize
rcurtin e8b0aa2
Use ElemType.
rcurtin 5454e99
Tune test to prevent failures.
rcurtin 01f3dd8
Fix use of ElemType---could this have caused slow convergence?
rcurtin e51b5c0
Remove unnecessary parts of file (or some of them at least).
rcurtin 00e2680
Recomment accidentally-committed random seed setting.
rcurtin 3c72dae
Merge branch 'master' into templated_optimize
rcurtin a8a2ff0
Minor type fixing.
rcurtin 00c0c79
This change caused more problems than it fixed.
rcurtin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the new template parameters aren't listed in the method documentation, perhaps this is intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no, it was just an oversight, thanks. Fixed in d7cb084.