Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed note on cmake requirements #169

Merged
merged 2 commits into from Feb 19, 2020
Merged

proposed note on cmake requirements #169

merged 2 commits into from Feb 19, 2020

Conversation

conradsnicta
Copy link
Contributor

No description provided.

@conradsnicta conradsnicta mentioned this pull request Feb 19, 2020
Merged
rcurtin
rcurtin reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to write up a patch based on your comment on #152, but it looks like you beat me to it. :) Just a couple notes, let me know what you think. We should add this note to the README for sure though.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@conradsnicta @rcurtin
more details
55e5f72 
Co-Authored-By: Ryan Curtin <ryan@ratml.org>
@favre49
Copy link
Member

favre49 commented Feb 19, 2020

It seems I forgot to put the change in HISTORY.md as well. I can create another PR for this, or we can include it in this. Either works.

@rcurtin
Copy link
Member

rcurtin commented Feb 19, 2020

It seems I forgot to put the change in HISTORY.md as well. I can create another PR for this, or we can include it in this. Either works.

I meant to do this during merge but I forgot. I'll open a PR in a second since I already have the modifications handy.

rcurtin
rcurtin approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to approve it.

zoq
zoq approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@zoq zoq merged commit f765334 into master Feb 19, 2020
@zoq zoq deleted the conradsnicta-readme-cmake-note branch February 19, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@zoq zoq zoq approved these changes

@birm birm birm approved these changes

Assignees
No one assigned
Labels
c: documentation t: added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@conradsnicta @favre49 @rcurtin @zoq @birm