Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused const to fix compilation warnings #259

Merged
merged 2 commits into from Mar 3, 2021

Conversation

rcurtin
Copy link
Member

@rcurtin rcurtin commented Feb 27, 2021

Another pretty simple PR. It should fix many warnings that I see when I compile mlpack.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this needs a history entry?

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin
Copy link
Member Author

rcurtin commented Mar 2, 2021

Agreed, the changelog entry should fix the Travis build too.

@rcurtin
Copy link
Member Author

rcurtin commented Mar 2, 2021

@mlpack-jenkins test this please

1 similar comment
@rcurtin
Copy link
Member Author

rcurtin commented Mar 2, 2021

@mlpack-jenkins test this please

@rcurtin
Copy link
Member Author

rcurtin commented Mar 3, 2021

The memory checks timed out, but it looks like there were no errors. I'll go ahead and merge. 👍

@rcurtin rcurtin merged commit a449d5e into mlpack:master Mar 3, 2021
@rcurtin rcurtin deleted the warning-fix branch March 3, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants