Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved installation and compilation instructions #300

Merged
merged 7 commits into from
Jun 24, 2021

Conversation

conradsnicta
Copy link
Contributor

Improved installation and compilation instructions:

  • show how to install manually (in addition to cmake)
  • show how to install with and without root access
  • added example compilation commands, using standard and non-standard installation directories

Improved installation and compilation instructions:
* show how to install manually (in addition to cmake)
* show how to install with and without root access
* added example compilation commands, using standard and non-standard installation directories
@conradsnicta
Copy link
Contributor Author

Related PR: #297

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petty comprehensive instructions and I think covers the comment from the reviewer.

@zoq zoq removed the s: unanswered label Jun 23, 2021
README.md Outdated Show resolved Hide resolved
* place automatic installation instructions before manual installation instructions
* adapt text to improve flow
* fix bug in path for cmake non-root installation
clarify wording, as the cmake installation isn't really automatic (still need to type commands)
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I'll normalize the line widths to match the rest of the file when merging. 👍

@conradsnicta
Copy link
Contributor Author

@rcurtin I've adjusted the line lengths to 80 chars max. The conflict with HISTORY.md has also been resolved.

@rcurtin
Copy link
Member

rcurtin commented Jun 24, 2021

Thanks! You have made my life easier. 😄

@rcurtin rcurtin merged commit e6406a5 into master Jun 24, 2021
@conradsnicta conradsnicta deleted the README-improved-install-instructions branch June 25, 2021 01:07
@zoq zoq mentioned this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants