New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum Armadillo version to 9.800. #318
Conversation
…paces in README.md.
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second approval provided automatically after 24 hours. 👍
When this is merged, we should also bump it in mlpack, otherwise we can get a situation where mlpack's Armadillo version requirement is less than ensmallen's, so a user could feasible download mlpack, download Armadillo 8.400.0, think "I'm good to go!", then suddenly find out that the newest ensmallen (via the autodownloader) actually needs an even newer version. |
It is strange the error says it is unable to find Armadillo on windows |
I'll fix the windows build. |
The auto-downloader downloads the ensmallen master branch? If that is the case, we should change that behavior, it should always download the latest stable version. Anyway, I'll open another PR on mlpack. With the release of another ensmallen, I also open a second PR to update ensmallen.org. |
Right, it just downloads the latest stable version. So, we should just merge mlpack/mlpack#3043 before releasing another version of ensmallen. 👍 |
As discussed here #315 we like to bump the minimum Armadillo version to 9.800. I think once merged we should do another release
2.18.0
.