Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Armadillo version to 9.800 #3043

Merged
merged 2 commits into from Aug 31, 2021

Conversation

zoq
Copy link
Member

@zoq zoq commented Aug 29, 2021

Bump minimum Armadillo version to 9.800.6, see mlpack/ensmallen#318 for more details.

Copy link
Member

@shrit shrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we merge this, would it resolve the issue presented in #2953

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

CMakeLists.txt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/guide/build.hpp Outdated Show resolved Hide resolved
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once Conrad's comments are handled. Once this is merged, I'll update the CI build matrix to only use Armadillo 9.800 or newer. 👍

@conradsnicta conradsnicta changed the title Bump minimum Armadillo version to 9.800.6 Bump minimum Armadillo version to 9.800 Aug 31, 2021
@conradsnicta conradsnicta merged commit bee9b84 into mlpack:master Aug 31, 2021
This was referenced Oct 14, 2022
@rcurtin rcurtin mentioned this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants