Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCD partial gradient test fix #332

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

zoq
Copy link
Member

@zoq zoq commented Nov 18, 2021

Use the correct number of classes to generate the label vector. This will fix the build issue reported in #329.

HISTORY.md Outdated Show resolved Hide resolved
@conradsnicta
Copy link
Contributor

PS. it's probably worth releasing a patch release (2.18.1) after this fix is committed

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for putting the time into debugging this---it sounds like it was tedious to reproduce everything. All that work for a two-character fix 😄

@conradsnicta conradsnicta merged commit c35e78e into mlpack:master Nov 19, 2021
@zoq zoq mentioned this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants