Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a newline after printing coordinates to Report callback #385

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

rcurtin
Copy link
Member

@rcurtin rcurtin commented Nov 22, 2023

Pretty simple change... before:

Optimization Report
--------------------------------------------------------------------------------

Initial coordinates: 
 0.0000  0.0000  0.0000 ...
 0.0000 
Final coordinates: 
-2.3592 -0.0324 -0.0261 ...
-0.1400 iter          loss          loss change   |gradient|    step size     total time    
0             0.883         0.000         4.532         0.010         0.007         
10            0.762         0.121         0.000         0.010         0.078         
20            1.195         -0.433        867.404       0.010         0.136         
30            0.627         0.567         0.104         0.010         0.200         
40            0.660         -0.033        55.468        0.010         0.261         
50            0.733         -0.074        37.082        0.010         0.327         
60            0.561         0.172         4.335         0.010         0.389         
70            0.558         0.003         723.906       0.010         0.453         
80            0.696         -0.138        463.292       0.010         0.516         
90            0.654         0.043         451.552       0.010         0.581         

--------------------------------------------------------------------------------

After:

Optimization Report
--------------------------------------------------------------------------------

Initial coordinates: 
 0.0000  0.0000  0.0000 ...
 0.0000 
Final coordinates: 
-2.3592 -0.0324 -0.0261 ...
-0.1400 
iter          loss          loss change   |gradient|    step size     total time    
0             0.883         0.000         4.532         0.010         0.023         
10            0.762         0.121         0.000         0.010         0.097         
20            1.195         -0.433        867.404       0.010         0.154         
30            0.627         0.567         0.104         0.010         0.215         
40            0.660         -0.033        55.468        0.010         0.279         
50            0.733         -0.074        37.082        0.010         0.346         
60            0.561         0.172         4.335         0.010         0.411         
70            0.558         0.003         723.906       0.010         0.475         
80            0.696         -0.138        463.292       0.010         0.536         
90            0.654         0.043         451.552       0.010         0.601         

--------------------------------------------------------------------------------

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and low stakes to me!

@rcurtin rcurtin merged commit cbc90d8 into mlpack:master Nov 24, 2023
2 of 4 checks passed
@rcurtin rcurtin deleted the report-newline branch November 24, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants