Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tolerances for SPSA test. #97

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

rcurtin
Copy link
Member

@rcurtin rcurtin commented Mar 13, 2019

This should fail less than ~1 in 1000 times.

Thanks to @SuryodayBasak and @favre49 for pointing this out in IRC. 👍

This should fail less than ~1 in 1000 times.
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@zoq zoq merged commit 1e4117b into mlpack:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants