Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed segfault of convolutional vae #156

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Fixed segfault of convolutional vae #156

merged 1 commit into from
Jun 11, 2021

Conversation

hello-fri-end
Copy link
Contributor

@hello-fri-end hello-fri-end commented Jun 11, 2021 •
edited
Loading

Turned out, we also need to pass outputWidth & outputHeight to the constructor of transposed_convolution layer.

We can now close #84 #2978 2978

CC: @yaro5

zoq
zoq approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@mlpack-bot
Copy link

mlpack-bot bot commented Jun 11, 2021

Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in COPYRIGHT.txt and you haven't already, please feel free to push a change to this PR---or, if it gets merged before you can, feel free to open another PR.

In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍

@kartikdutt18 kartikdutt18 merged commit 0139e80 into mlpack:master Jun 11, 2021
@shrit
Copy link
Member

shrit commented Jun 11, 2021

@hello-fri-end thanks 👍

@shrit shrit mentioned this pull request Jun 11, 2021
Closed
@shrit
Copy link
Member

shrit commented Jun 11, 2021

@hello-fri-end Would you open the same pull request in order to resolve the same issue in the model repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoq zoq zoq approved these changes

@kartikdutt18 kartikdutt18 kartikdutt18 approved these changes

Assignees
No one assigned
Labels
s: fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VAE Model doesn't work.
4 participants
@hello-fri-end @shrit @zoq @kartikdutt18