Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlboard_logger callback #15

Merged
merged 99 commits into from Dec 4, 2020
Merged

mlboard_logger callback #15

merged 99 commits into from Dec 4, 2020

Conversation

jeffin143
Copy link
Member

Callback for Mlbaord_logger which can be passed to ens optimizer

jeffin143 and others added 30 commits June 13, 2020 00:24
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Co-authored-by: Ryan Birmingham <birm@rbirm.us>
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Copy link
Collaborator

@toshal-a toshal-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I have given a rough review. I hope you can resolve the ensmallen.hpp Let me know if you need any help in it.

tests/summarywriter_test.cpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
tests/callback_test.cpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
examples/callback.md Outdated Show resolved Hide resolved
examples/callback.md Outdated Show resolved Hide resolved
jeffin143 and others added 8 commits August 22, 2020 00:48
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
@jeffin143
Copy link
Member Author

@walragatver , I have written the function to log embedding histogram and image through callback but currently I don't have a good example to write, since I am really unsure of the use case. Once models repo is strong enough with some Image models we can use the image feature of call back till then we can keep the feature hidden.

Also if you have something in mind let me know for either of the three , any use case for embedding, histogram or image

@birm birm self-requested a review August 27, 2020 21:47
Copy link
Collaborator

@toshal-a toshal-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing some style and merge issues.

tests/summarywriter_test.cpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@toshal-a toshal-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

examples/callback.md Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
examples/callback.md Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@toshal-a toshal-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good logically. I have left some comments on it.

tests/callback_test.cpp Outdated Show resolved Hide resolved
tests/callback_test.cpp Outdated Show resolved Hide resolved
tests/callback_test.cpp Outdated Show resolved Hide resolved
tests/callback_test.cpp Outdated Show resolved Hide resolved
tests/callback_test.cpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
tests/callback_test.cpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
include/mlboard_logger.hpp Outdated Show resolved Hide resolved
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, despite a nitpick. Maybe the build will magically fix itself?

examples/callback.md Outdated Show resolved Hide resolved
Co-authored-by: Ryan Birmingham <birm@rbirm.us>
@jeffin143
Copy link
Member Author

@birm can you hit merge button if everything looks good
@walragatver do you want to take a look ?

@jeffin143 jeffin143 closed this Nov 1, 2020
@jeffin143 jeffin143 reopened this Nov 1, 2020
@birm
Copy link
Member

birm commented Dec 4, 2020

Sorry to keep you waiting 😟

@birm birm merged commit f667469 into mlpack:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants