New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlboard_logger callback #15
Conversation
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Co-authored-by: Ryan Birmingham <birm@rbirm.us>
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Restart build by fixing small style issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I have given a rough review. I hope you can resolve the ensmallen.hpp
Let me know if you need any help in it.
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
Co-authored-by: Toshal Agrawal <37237262+walragatver@users.noreply.github.com>
@walragatver , I have written the function to log embedding histogram and image through callback but currently I don't have a good example to write, since I am really unsure of the use case. Once models repo is strong enough with some Image models we can use the image feature of call back till then we can keep the feature hidden. Also if you have something in mind let me know for either of the three , any use case for embedding, histogram or image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing some style and merge issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good logically. I have left some comments on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, despite a nitpick. Maybe the build will magically fix itself?
Co-authored-by: Ryan Birmingham <birm@rbirm.us>
@birm can you hit merge button if everything looks good |
Sorry to keep you waiting 😟 |
Callback for Mlbaord_logger which can be passed to ens optimizer