Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image support #6
Add Image support #6
Changes from 59 commits
95d6aec
50d15db
ccca629
44c98e5
6256227
729bc7e
89cbb71
f2296db
2400744
f4073a6
9f30050
8a4510d
b713d80
94cd3d6
f8f66ce
0f2fa21
3bcb013
6d54375
2f0f552
4889f27
39b49c6
d78f2a4
a55e94e
5d538d1
2ec814d
945ffc6
8021834
8fa0c04
82ba251
a59bfa6
dbbd525
b0742f0
7a1ff58
430d1ea
acd0467
26edb81
5e54c88
320544b
21fff43
57fa2f5
7a8a418
c46c6a8
670dfc0
50e50a9
08303e2
2500923
7b0d27e
7a115ea
30ea45d
b275e13
43497f9
123e816
ab29bc8
320547d
a69999e
243b9aa
f0a266f
c678bd2
3afbb07
ced5692
bb77df5
7482237
10ffc99
339b290
a89d26f
4fbcb2a
e1d5360
208b646
185ded1
07d75a9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little lost; what's using the ARMA_*.cmake files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I have take then from ensmallen repo : https://github.com/mlpack/ensmallen/tree/master/CMake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove them. If I'm wrong, then just revert that commit.