Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test executable mlpack_test isn't built #3314

Closed
yurivict opened this issue Nov 16, 2022 · 1 comment
Closed

The test executable mlpack_test isn't built #3314

yurivict opened this issue Nov 16, 2022 · 1 comment

Comments

@yurivict
Copy link

It required this patch to build:

--- src/mlpack/tests/CMakeLists.txt.orig        2022-11-15 09:59:36 UTC
+++ src/mlpack/tests/CMakeLists.txt
@@ -4,7 +4,7 @@ message("YURI: in tests")
 
 # mlpack test executable.
 add_executable(mlpack_test
-  EXCLUDE_FROM_ALL
+  #EXCLUDE_FROM_ALL
   ${MLPACK_TEST_SRCS}
  
   # Tests for neural network code (and reinforcement learning code).

Version: 4.0.0
cmake-core-3.24.3_1
FreeBSD 13.1

@rcurtin
Copy link
Member

rcurtin commented Nov 16, 2022

Thanks for the report @yurivict! I spent a while thinking about the right solution here, but I agree with your patch in the end. I opened a PR in #3316. There is a little bit more to it too. This will be a part of the 4.0.1 release (we are still collecting little configuration bugfixes, but that should happen soon enough).

conradsnicta pushed a commit that referenced this issue Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants