Set default for BUILD_TESTS to OFF. #3316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have the CMake option
BUILD_TESTS
set toON
, but thenmlpack_test
is not a part of theall
target---it specifically has anEXCLUDE_FROM_ALL
marking. The reason for this is so that users do not accidentally compile the tests, which take a really long time.But, it's also reasonable to just set
BUILD_TESTS
toOFF
by default! Then, whenBUILD_TESTS
isON
, we know the user means to build the tests, and we can make it part of theall
target.I also added a convenience script that displays this error if you try to run
make mlpack_test
withBUILD_TESTS
set toOFF
: