Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unused result warning #1374

Merged
merged 1 commit into from Apr 22, 2018
Merged

fix unused result warning #1374

merged 1 commit into from Apr 22, 2018

Conversation

conradsnicta
Copy link
Contributor

As per #1373

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll go ahead and merge this when #1373 is merged.

Do you want to add your name to the list of contributors? (or I can do it for you if you like) Even though it is a simple change it is still a change to the code.

We also mail mlpack stickers to contributors so if you want I can toss some in an envelope and send them to you...

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport, no comments from my side.

@rcurtin rcurtin merged commit f45e829 into mlpack:mlpack-3.x Apr 22, 2018
@conradsnicta
Copy link
Contributor Author

@rcurtin - if the contribution is sufficient, then adding to the list of contributors sounds good (but please don't include my email address).

I'll have to make more contributions before deserving the stickers :)

@conradsnicta conradsnicta deleted the mlpack-3.x branch April 23, 2018 09:08
@rcurtin
Copy link
Member

rcurtin commented Apr 25, 2018

Sure, added in 46eb0a0 with no email. I have international stamps so it is easy for me to mail stickers, so just let me know if you ever want any. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants