Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add SSRBM CIFAR-10 Test #1477

Closed
wants to merge 2 commits into from
Closed

Conversation

ShikharJ
Copy link
Member

Relevant: #1207

double slabPenalty = 10.5;
double lambdaBias = 10;

if (!CLI::HasParam("dataset"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the test we can just hardcode the dataset, no need to use the cli methods.

@mlpack-bot
Copy link

mlpack-bot bot commented Feb 18, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@Rajiv2605
Copy link
Contributor

@ShikharJ @zoq I'll work on this issue 👍

@Rajiv2605
Copy link
Contributor

@ShikharJ @zoq I am able to import data into arma::mat. According to the CIFAR-10 documentation,
The binary version contains the files formatted as follows:
<1 x label><3072 x pixel>
The dimension of the armadillo matrix after .load() is: 3841250 x 1
I tried this code:
std::cout<<testData(0, 0)<<std::endl;
and also this,
std::cout<<testData(3073, 0)<<std::endl;
but both are not giving me the class number.
I also tried reshaping and extracting the first row thinking that it would be the set of labels:

trainData = arma::reshape(trainData, 3073, 1250);
trainLabels = trainData.col(0);

but even that is not giving me the class labels. What mistake am I making?

@zoq
Copy link
Member

zoq commented Mar 30, 2019

Sorry for the slow response, which format (binary,matlab,python,csv) of the dataset do you use?

@heisenbuug
Copy link
Contributor

I was actually thinking of taking this as my GSoC project. Can you tell me what all work needs to be done so I can create an effective proposal.

@Rajiv2605
Copy link
Contributor

Sorry for the slow response, which format (binary,matlab,python,csv) of the dataset do you use?

@zoq I am using binary format for the dataset.

@khizirsiddiqui
Copy link
Contributor

Hey, I was thinking to complete the PR. While building the PR, cmake produces error: make[3]: *** No rule to make target '../src/mlpack/core/arma_extend/fn_ccov.hpp', needed by 'src/mlpack/cotire/mlpack_CXX_prefix.hxx.gch'. Stop. This filename doesn't exist in master branch at least, was this file renamed or something?

@rcurtin
Copy link
Member

rcurtin commented Jan 15, 2020

Clearing your build directory and reconfiguring CMake from scratch should fix that, or alternately, maybe fn_ccov.hpp is still referenced on this branch somewhere in some CMakeLists.txt file?

@khizirsiddiqui
Copy link
Contributor

@rcurtin I couldn't find fn_ccov.hpp anywhere in tests/CMakeLists.txt or any other cmake file. Isn't this strange?
Honestly, I do not know much about writing CMake files, so I will give it a try after reading through some relevant tutorials. 👍

@rcurtin
Copy link
Member

rcurtin commented Jan 15, 2020

It may be leftover from a previous build; we removed fn_ccov.hpp some time ago. Did you try clearing the build directory? It's also possible that fn_ccov.hpp is referenced somewhere in the codebase on this branch, so be sure to search through every file; for instance with grep or something.

@rcurtin
Copy link
Member

rcurtin commented Mar 12, 2020

This code touches the ANN code, and there was recently a big refactoring of the ANN code in #2259, so be sure to merge the master branch into your branch here to make sure that nothing will fail if this PR is merged. 👍 (I'm pasting this message into all possibly relevant PRs.)

@birm birm marked this pull request as draft May 21, 2020 18:15
@mlpack-bot mlpack-bot bot closed this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants