Pixel Shuffle layer

[iamshnoo]

Pixel Shuffle layer

To compare PyTorch/numpy implementation with mlpack/armadillo implementation of the functionality, check this Google Colab notebook.

[sreenikSS]

Looks good to me. Just take care of the conflicts and I'll merge it.

[mlpack-bot]

Second approval provided automatically after 24 hours. 👍

[sreenikSS]

Could you fix this once more?

[birm]

Marking changes requested until build is fixed :)

[kartikdutt18]

Resolving the conflict here.

[iamshnoo]

Any clue regarding the failing tests on this one?
When it was approved previously, the build was passing with all tests. However, currently it doesn't compile !? 👀
Not sure if there is something I need to add from my end.

[zoq]

Any clue regarding the failing tests on this one?
When it was approved previously, the build was passing with all tests. However, currently it doesn't compile !? 👀
Not sure if there is something I need to add from my end.

Can you merge in or rebase against the latest master branch?

[rcurtin]

Looks like this one is pretty close to ready---should I put it in the mlpack 3.4.2 milestone? I'm hoping to do a quick release in the next couple days. :)

[iamshnoo]

Yep, from my end, the implementation of this feature is complete. All it would need is pulling in the recent changes, before we can merge this. So, you can add it to the 3.4.2 milestone, yes :)

[zoq]

Merged the latest master banch in, let's see if the CI pipeline comes back green.

[abhinav-anand-addepar]

@zoq Can i take over this PR?

[zoq]

@zoq Can i take over this PR?

Let's see what @iamshnoo says, with the recent switch from boost serialization to cereal, we have to update the PR.

[iamshnoo]

It's fine with me if @abh2k would like to update the PR. I guess the only change would be in the serialize() method, right?

[abhinav-anand-addepar]

Thanks. I will update the pr.

[birm]

Oh cool, since the followup, #2833 was merged, github automatically tagged this as merged too!