Add PYTHON_INSTALL_PREFIX CMake option #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I will try it today and let you know. Thanks. |
|
The install with PYTHON_INSTALL_PREFIX=/path/to/anaconda3 worked for me on Ubuntu 20.04. FYI there is still a missing closing ")" on line 233 of https://github.com/mlpack/mlpack/blob/master/src/mlpack/bindings/R/CMakeLists.txt for the closing ")" of the |
|
@BJWiley233 nice catch, thanks! |
|
@Yashwants19 just FYI, I fixed the missing brace for the R binding installation in this PR. Let me know if a deeper change was needed. :) |
Yashwants19
reviewed
Jan 6, 2021
Co-authored-by: Yashwant Singh Parihar <Yashwantsingh.sngh@gmail.com>
Yashwants19
approved these changes
Jan 14, 2021
This was referenced Oct 14, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes out of the discussion in #2775.
Right now, the Python bindings will simply be installed to
CMAKE_INSTALL_PREFIX, even ifPYTHON_EXECUTABLEis set to some other location. This PR does not automatically extract the path of the Python installation fromPYTHON_EXECUTABLE, but simply adds aPYTHON_INSTALL_PREFIXoption so that a separate location for the Python bindings to be installed can be specified.@BJWiley233 do you think that you could try these changes and see if they work correctly?