Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Coverage, no longer used #2866

Merged
merged 4 commits into from Mar 12, 2021
Merged

Clean Coverage, no longer used #2866

merged 4 commits into from Mar 12, 2021

Conversation

shrit
Copy link
Member

@shrit shrit commented Mar 9, 2021

Signed-off-by: Omar Shrit omar@shrit.me

Signed-off-by: Omar Shrit <omar@shrit.me>
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the badge from the https://github.com/mlpack/mlpack/blob/master/README.md as well?

@shrit
Copy link
Member Author

shrit commented Mar 10, 2021

Of course, I will remove the badge.
Also, do we need to keep the appveyor script? I can open another pull request for that one too

Signed-off-by: Omar Shrit <omar@shrit.me>
@zoq
Copy link
Member

zoq commented Mar 10, 2021

Of course, I will remove the badge.
Also, do we need to keep the appveyor script? I can open another pull request for that one too

We don't, don't mind to remove the script as part of the PR as well.

Signed-off-by: Omar Shrit <omar@shrit.me>
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I may have missed some conversation on removing versus fixing coverage builds.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking the time to do this. I see there's a reference to BUILD_WITH_COVERAGE in doc/guide/build.hpp---do you think you can remove that too?

@birm basically the coverage build has been failing for a very long time and doesn't have an "owner", so we thought it was reasonable to remove it. (If anyone feels strongly and wants to bring it back, that's totally ok! I just don't think anyone does. :))

Signed-off-by: Omar Shrit <omar@shrit.me>
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me. 👍

@rcurtin rcurtin merged commit f2a06ef into mlpack:master Mar 12, 2021
This was referenced Oct 14, 2022
@rcurtin rcurtin mentioned this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants