Remove ElemType template parameter from DecisionTree #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoq
reviewed
Mar 14, 2021
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
birm
approved these changes
Mar 17, 2021
|
We've already done the last 3.x release, since we've made a bunch of not-reverse-compatible changes, so let's go ahead and merge it now. 👍 |
This was referenced Oct 14, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing #2872, I noticed that there is a template parameter
ElemTypeforDecisionTreeandRandomForestthat is currently entirely unused. In fact, it gets in the way and is confusing a little bit, so I thought it was better to remove it.In addition, I changed some function signatures to force
arma::vecfor theclassProbabilitiesmember to actually fix #2872.This is an API change, but since the next release is 4.0.0 anyway, it should be okay to break reverse compatibility in this minor way.