Handle empty OpenMP_CXX_FLAGS correctly #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zoq reported yesterday that a build with Python and
-DUSE_OPENMP=OFFfails. As it turns out, the reason for this is that an empty argument gets appended to the list of compilation flags, and then when those are joined with a space, we end up with two spaces in the compilation command. For whatever reason, setuptools/cython does not like this, and it causes a compilation failure with a strange error message:https://gist.github.com/zoq/8d65e3caf0a58ef9772e8466caeaf3cc
I fixed the issue by only adding
${OpenMP_CXX_FLAGS}to the list of compilation arguments if it isn't empty.