The Autodownloader. #2927
The Autodownloader. #2927
Conversation
This pull request provides the Autodownloader for mlpack dependencies. It can be used with current and future dependencies. This one is born from working with mlpack#2531, with help from @rcurtin and @zoq. It is ready to merge, with minor reviews are always welcome. Signed-off-by: Omar Shrit <omar@shrit.me>
Signed-off-by: Omar Shrit <omar@shrit.me>
zoq
added
c: build system
t: added feature
and removed
s: unanswered
s: unlabeled
labels
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
| else() | ||
| find_package(Armadillo "${ARMADILLO_VERSION}") | ||
| if (NOT ARMADILLO_FOUND) | ||
| get_deps(http://files.mlpack.org/armadillo-10.3.0.tar.gz armadillo armadillo-10.3.0.tar.gz) |
There was a problem hiding this comment.
I am not sure, But I guess we can maintained a copy of the latest armadillo tarball(armadillo-latest.tar.gz) same as ensmallen at our website. Let me know what you think??
| else() | ||
| find_package(cereal "${CEREAL_VERSION}") | ||
| if (NOT CEREAL_FOUND) | ||
| get_deps(https://github.com/USCiLab/cereal/archive/refs/tags/v1.3.0.tar.gz cereal cereal-1.3.0.tar.gz) |
There was a problem hiding this comment.
Can we some how fetch the latest version of cereal before downloading it???
| else() | ||
| find_package(Boost "${BOOST_VERSION}") | ||
| if (NOT Boost_FOUND) | ||
| get_deps(https://dl.bintray.com/boostorg/release/1.75.0/source/boost_1_75_0.tar.gz boost boost_1_75_0.tar.gz) |
There was a problem hiding this comment.
| get_deps(https://dl.bintray.com/boostorg/release/1.75.0/source/boost_1_75_0.tar.gz boost boost_1_75_0.tar.gz) | |
| list(GET Boost_ADDITIONAL_VERSIONS 0 Boost_LATEST_VERSION_1) | |
| string(REPLACE "." "_" Boost_LATEST_VERSION_2 ${Boost_LATEST_VERSION_1}) | |
| get_deps(https://dl.bintray.com/boostorg/release/${Boost_LATEST_VERSION_1}/source/boost_${Boost_LATEST_VERSION_2}.tar.gz boost boost_${Boost_LATEST_VERSION_2}.tar.gz) |
As latest version of boost is maintained by actions, we can rely on Boost_ADDITIONAL_VERSIONS, and Hence we can get rid of updating the version of boost regularly here. Let me know what you think???
Sorry about that! I guess I hit merge too fast 😄 |
|
@rcurtin @Yashwants19 no worries I can open another pull request to change later to the latest version for cereal and armadillo, but we need to host the last version on mlpack.org. |
This pull request provides the Autodownloader for mlpack dependencies.
It can be used with current and future dependencies.
This one is born from working with #2531, with help from @rcurtin and @zoq.
It is ready to merge, with minor reviews are always welcome.