If we are building mlpack statically then build executable statically #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… too This pull request is not related to cross-compilation. Signed-off-by: Omar Shrit <omar@shrit.me>
rcurtin
reviewed
Apr 25, 2021
|
Do you have a specific file in mind to update? for example |
|
The original PR had some modifications to the documentation of the options in |
|
Exactly, the modifications related to the main |
Signed-off-by: Omar Shrit <omar@shrit.me>
rcurtin
reviewed
Apr 29, 2021
rcurtin
reviewed
Apr 29, 2021
Co-authored-by: Ryan Curtin <ryan@ratml.org>
Co-authored-by: Ryan Curtin <ryan@ratml.org>
|
@rcurtin, sorry I forget about the readme, I will add one line to declare the option 👍 |
Signed-off-by: Omar Shrit <omar@shrit.me>
rcurtin
approved these changes
Apr 29, 2021
Co-authored-by: Ryan Curtin <ryan@ratml.org>
Co-authored-by: Ryan Curtin <ryan@ratml.org>
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
|
Awesome, thanks! 👍 |
|
You are most welcome, I will open one tomorrow for the embedded system 👍 |
This was referenced Oct 14, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not related to cross-compilation.
Signed-off-by: Omar Shrit omar@shrit.me