Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notes for usage on RHEL7 #2955

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

rcurtin
Copy link
Member

@rcurtin rcurtin commented May 25, 2021

This comes from the discussion in #2939.

  • I added a check to our CMake configuration to ensure that, if GCC is used, version 5.x or newer is used.
  • I added some documentation for what to do on RHEL7/CentOS 7, where the default version of GCC is 4.8.

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@conradsnicta
Copy link
Contributor

* I added a check to our CMake configuration to ensure that, if GCC is used, version 5.x or newer is used.

If we're bumping the minimum GCC version, might as well jump to version 6 or even 7. No point in living in the ancient past.

GCC 6 is the first version with stable C++11/C++14 support, including the standard library components. The default compilation mode in GCC 6 is C++14. GCC 6 was released in April 2016 (ie. more than 5 years ago).

@rcurtin
Copy link
Member Author

rcurtin commented May 26, 2021

@conradsnicta I see where you're coming from, but as far as I know mlpack successfully compiles on gcc 5.x still, so I don't really want to force a user to upgrade unless the software actually will not work. If we ever find that mlpack just plain no longer compiles on gcc 5.x, and it's also true that no reasonably-recent common distributions provide it, then I think that's good impetus to bump the minimum version, but at least personally I don't see the need to do so until that time.

@rcurtin rcurtin merged commit ecc759b into mlpack:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants