CI Fix #3116
CI Fix #3116
Conversation
Removed warning in padding layer
|
Thanks for looking into this. |
|
There is some issue with macOS 11 for R. |
CMakeLists.txt
Outdated
| # extract V from '11.V.x'. | ||
| exec_program(/usr/bin/sw_vers ARGS | ||
| -productVersion OUTPUT_VARIABLE MACOSX_VERSION_RAW) | ||
| string(REGEX REPLACE | ||
| "10\\.([0-9]+).*" "\\1" | ||
| "11\\.([0-9]+).*" "\\1" | ||
| MACOSX_VERSION |
There was a problem hiding this comment.
Are you sure this modification will work as you change the version to 10 now?
There was a problem hiding this comment.
It is working as for now.
I was trying to fix the following.
ld: warning: dylib (/Users/runner/work/1/s/build/lib/libmlpack.dylib) was built for newer macOS version (11.6) than being linked (10.14)
ld: warning: dylib (/usr/local/lib/libarmadillo.dylib) was built for newer macOS version (11.0) than being linked (10.14)
But its not fixed rn.
There was a problem hiding this comment.
I think I overlooked the details of these lines of code.
But why is there \ after 11?
And better regex shouldn't be 11.([0-9]+)((.[0-9]+)*)
As version can be of form 11.V only.
I will change 11 to 10 back.
There was a problem hiding this comment.
([0-9]+)(?:.([0-9]+).)
| inputWidth(inputHeight), | ||
| inSize(0) |
There was a problem hiding this comment.
I would open another PR just for this one, and remove it from here, this will help us better keep tracking what this PR is doing on the CI fix, since this is not related directly to the CI
There was a problem hiding this comment.
It's just warning removal actually. You can do whatever you want to do.
Added no_deprycated_api use in numpy
Trying to update old numpy code
trying to add cdef
|
I will close this PR. And open separate ones once correction is done. |
Updated Deprecated API
Updated macOS version in CMake file.
Removed warning in the Padding layer