Numpy Deprecated Code Replacement

[shubham1206agra]

• Disabled use of Deprecated Numpy API use by defining kwarg in Extension in setup.py.in

define_macros=[('NPY_NO_DEPRECATED_API', 'NPY_1_7_API_VERSION')]

which will turn it in c++ into

#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION

• Changing direct use of members of PyArrayObject to function based access

1. X.data changes to PyArray_DATA(X)
2. X.shape changes to PyArray_SHAPE(X)
3. X.flags changes to PyArray_FLAGS(X)

• Changed NPY_OWNDATA to NPY_ARRAY_OWNDATA
• Changed the if logic

if not X.flags.c_contiguous or (not X.flags.owndata and not isWin)

to

if not (flags & numpy.NPY_ARRAY_C_CONTIGUOUS) or (not (flags & numpy.NPY_ARRAY_OWNDATA) and not isWin)

[rcurtin]

This is awesome! Thank you so much for taking the time to fix this issue. I really like little code maintenance PRs like this. 💯 I tested the build myself and indeed, no more warnings. 🚀

I only have a couple little comments relating to style, and then we should definitely merge this. 👍

[shubham1206agra]

You may merge now.

[rcurtin]

Thanks! I really appreciate this PR. Would you like to add an entry to CHANGELOG.md? 👍

[mlpack-bot]

Second approval provided automatically after 24 hours. 👍

[rcurtin]

Thanks @shubham1206agra!