-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move R Github Actions workflow to r-lib/actions@v2 #3296
Conversation
The R GitHub action referencing r-lib/actions@master is stalled out. We need to migrate over to using r-lib/actions@v2. Within this PR, we attempt to address this issue. Discussion on matrix.
@@ -3,9 +3,11 @@ on: | |||
push: | |||
branches: | |||
- master | |||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, are we planning on renaming master to main at any point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any strong opinion on it. If someone wants to take the lead on seeing if that's a thing the community wants, I don't have any issue with it. If you like, feel free to make an issue about it, or post to the contributors team, and we can figure out what people think. 👍 (I don't imagine anyone would have a problem with it, but good to find out first.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward and seems to work just fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this looks good to me too. Thanks @coatless for putting the time into fixing this!
The R GitHub action referencing r-lib/actions@master is stalled out. We need to migrate over to using r-lib/actions@v2. Within this PR, we attempt to address this issue.
Discussion on matrix.