Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move R Github Actions workflow to r-lib/actions@v2 #3296

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Conversation

coatless
Copy link
Contributor

The R GitHub action referencing r-lib/actions@master is stalled out. We need to migrate over to using r-lib/actions@v2. Within this PR, we attempt to address this issue.

Discussion on matrix.

The R GitHub action referencing r-lib/actions@master is stalled out. We need to migrate over to using r-lib/actions@v2. Within this PR, we attempt to address this issue. 

Discussion on matrix.
@@ -3,9 +3,11 @@ on:
push:
branches:
- master
- main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, are we planning on renaming master to main at any point?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any strong opinion on it. If someone wants to take the lead on seeing if that's a thing the community wants, I don't have any issue with it. If you like, feel free to make an issue about it, or post to the contributors team, and we can figure out what people think. 👍 (I don't imagine anyone would have a problem with it, but good to find out first.)

@birm birm self-requested a review October 26, 2022 04:49
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and seems to work just fine!

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks good to me too. Thanks @coatless for putting the time into fixing this!

rcurtin added a commit that referenced this pull request Oct 26, 2022
@rcurtin rcurtin merged commit 470eb26 into master Oct 26, 2022
@rcurtin rcurtin deleted the r-gh-actions-update branch October 26, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants