Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codes and improve doc #3401

Merged
merged 4 commits into from Feb 12, 2023
Merged

Fix codes and improve doc #3401

merged 4 commits into from Feb 12, 2023

Conversation

AdarshSantoria
Copy link
Contributor

Fixed the code example in doc as mentioned in #3397 and some other doc fixes.

rcurtin
rcurtin approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. 👍 Once #3398 is merged, do you want to add this PR to the general entry in HISTORY.md?

mlpack-bot[bot]
mlpack-bot bot approved these changes Feb 12, 2023
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin
Copy link
Member

rcurtin commented Feb 12, 2023

Do you mind adding this PR to HISTORY.md? You can just add the PR number to the changelog entry here: https://github.com/mlpack/mlpack/blob/master/HISTORY.md?plain=1#L4

@AdarshSantoria
Copy link
Contributor Author

Yes I will submit a fresh pr for this as it's causing conflicts.

@AdarshSantoria AdarshSantoria mentioned this pull request Feb 12, 2023
Merged
@rcurtin
Copy link
Member

rcurtin commented Feb 12, 2023

Ok, sure---I think that you just merged the conflict successfully and could now make the changes, but #3414 is fine too. 👍

@rcurtin rcurtin merged commit a8fe2ff into mlpack:master Feb 12, 2023
@rcurtin rcurtin mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@mlpack-bot mlpack-bot[bot] mlpack-bot approved these changes

Assignees
No one assigned
Labels
c: documentation t: bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AdarshSantoria @rcurtin