Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HISTORY.md #3414

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Update HISTORY.md #3414

merged 3 commits into from
Feb 17, 2023

Conversation

AdarshSantoria
Copy link
Contributor

Mentioning #3401 #3404 #3413 in HISTORY.md

@rcurtin rcurtin mentioned this pull request Feb 12, 2023
Merged
rcurtin
rcurtin reviewed Feb 12, 2023
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together---I have some suggestions on how we can keep the changelog shorter and easier to read for users. 👍

HISTORY.md Outdated Show resolved Hide resolved
HISTORY.md Outdated Show resolved Hide resolved
AdarshSantoria and others added 2 commits February 13, 2023 01:20
@AdarshSantoria @rcurtin
Update HISTORY.md
e3bd456 
Co-authored-by: Ryan Curtin <ryan@ratml.org>
@AdarshSantoria @rcurtin
Update HISTORY.md
da0fdb4 
Co-authored-by: Ryan Curtin <ryan@ratml.org>
rcurtin
rcurtin approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; let's wait until #3404 and #3413 are merged to merge this. 👍 Thanks!

mlpack-bot[bot]
mlpack-bot bot approved these changes Feb 15, 2023
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@rcurtin rcurtin merged commit c6c54aa into mlpack:master Feb 17, 2023
@AdarshSantoria AdarshSantoria deleted the history branch February 22, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@mlpack-bot mlpack-bot[bot] mlpack-bot approved these changes

Assignees
No one assigned
Labels
s: unanswered s: unlabeled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AdarshSantoria @rcurtin