Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt softmin layer #3437

Merged
merged 3 commits into from Mar 19, 2023
Merged

Adapt softmin layer #3437

merged 3 commits into from Mar 19, 2023

Conversation

theshoonyam
Copy link
Contributor

An attempt to adapt softmin layer according to changes in #2777.

rcurtin
rcurtin approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @Aadi-Raj. I think everything is good here. Do you want to add a note to HISTORY.md?

src/mlpack/methods/ann/layer/serialization.hpp Show resolved Hide resolved
mlpack-bot[bot]
mlpack-bot bot approved these changes Mar 18, 2023
View reviewed changes
Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@conradsnicta conradsnicta merged commit 5453cb8 into mlpack:master Mar 19, 2023
15 checks passed
@rcurtin rcurtin mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@AdarshSantoria AdarshSantoria AdarshSantoria left review comments

@mlpack-bot mlpack-bot[bot] mlpack-bot approved these changes

Assignees
No one assigned
Labels
c: methods s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@theshoonyam @rcurtin @AdarshSantoria @birm @conradsnicta