Optimize load csv #678
Closed
Optimize load csv #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication problem with n classes.
…itm for classification models. To be precise, this is is a Variance Reduces classification reinforcement learning rule.
…xtract a retina-like representation of the input image.
…ilable afterwards.
Properly use Enum type.
Typo fix in knn_main.cpp
Instead of including: methods/neighbor_search/ns_traversal_info.hpp Include the definition in: core/tree/traversal_info.hpp
Properly use Enum type, in rann and range_search.
Remove duplicated code for traversal info.
Deprecated arma function replaced by new arma constant
…ples. So we'll have to wait until mlpack 2.0.1 to remove it... :(
add cli executable for data_split
Add B_aux according to issue mlpack#642
Marcus thinks this will fix the Windows build... let's find out.
Fix mapping issue
More tests for DatasetInfo
2 : fix bug, cannot parse transpose file with correct result
nilayjain
force-pushed
the
master
branch
2 times, most recently
from
fddfc18
to
1f562a1
Compare
|
Why there are so many commits on this branch suddenly? |
|
@stereomatchingkiss hmm... did you amend it with the merge commit? |
|
Someone force pushed to the repo and I am in the process of fixing it. That will fix this problem. |
No, I only merge pull request(#650) one time.
Thanks for the fix. Edit : Already integrate into load_impl.hpp, pass all of the test cases |
|
@rcurtin Would it make things easier to deal with if I delete this branch and open a new one? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I use boost::spirit to implement the csv parser, it is more memory efficient and faster.
parse file with 1 million lines, 39796KByte
spirit version :
transpose : 2151 msec
non transpose : 4073 msec
old version :
transpose : 9616 msec
non transpose : 10131 msec
non transpose version is slower, I guess it is because arma::Mat is column wise.
Upload for code reviews, haven't integrate it into the load function and run the test cases yet.
ps : Single thread only, do not know multi-thread can make performance become better or worse, DataSetInfo is not a lock free data structure. If we want to utilize the power of multi-thread, I think we could read a bunch of string into the vector, create thread pool and DataSetInfo vectors, merge the DataSetInfo at last.