Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move everything one directory up #2

Closed
jakob-r opened this issue Jun 26, 2015 · 17 comments
Closed

move everything one directory up #2

jakob-r opened this issue Jun 26, 2015 · 17 comments
Assignees

Comments

@jakob-r
Copy link
Contributor

jakob-r commented Jun 26, 2015

http://mlr-org.github.io/mlr-tutorial/tutorial/ is just to redundant.
http://mlr-org.github.io/mlr-tutorial/release/html/ is how it should look like.
Any thoughts?
I would just need an ok and a lock to change all links.

@schiffner
Copy link
Contributor

I'm not opposed, but would like to let @larskotthoff decide, because he built the directory structure.

@larskotthoff
Copy link
Contributor

Fine with me.

@jakob-r jakob-r self-assigned this Jun 30, 2015
@jakob-r
Copy link
Contributor Author

jakob-r commented Jul 1, 2015

I will do it now

jakob-r added a commit that referenced this issue Jul 1, 2015
jakob-r added a commit that referenced this issue Jul 1, 2015
@jakob-r
Copy link
Contributor Author

jakob-r commented Jul 1, 2015

Okay - i am mainly finished - waiting for travis to pass

@schiffner
Copy link
Contributor

Big thanks!

larskotthoff pushed a commit that referenced this issue Jul 2, 2015
This reverts commit 5aad595.

Conflicts:
	README.md
larskotthoff pushed a commit that referenced this issue Jul 2, 2015
This reverts commit 68026e0.
larskotthoff pushed a commit that referenced this issue Jul 2, 2015
This reverts commit e2abd94.

Conflicts:
	README.md
@larskotthoff
Copy link
Contributor

Ok, for some reason this fails in Travis (see https://travis-ci.org/mlr-org/mlr-tutorial/builds/69224059). I can't reproduce this locally.

The commits break the published tutorial, so I've reverted everything for now -- this needs to work while useR is going on. All the changes are in a new branch gh-pages-move that we can come back to next week.

@larskotthoff
Copy link
Contributor

So the error seems to be completely unrelated -- Travis is and stays broken. I've pushed a hand-generated version so that the tutorial itself works at least.

I'm going to continue investigating what's happening next week (after useR) unless somebody has an idea what's going on here?

@schiffner
Copy link
Contributor

Sorry, was away last evening, otherwise I could have clarified things earlier: @jakob-r 's changes are indeed unrelated. Before failing, the travis build #69 worked, but ran into a 50 min error. I restarted it several times, but had no luck. I will go over the tutorial next week and see if I can make things cheaper.

After installing mlr HEAD I can reproduce the error in building the tutorial locally.
It's related to the latest changes in plotThreshVsPerf(l. 98 - 102 in https://github.com/berndbischl/mlr/blob/c6e7d591cbdba2703971bd851fc62ead33845628/R/generateThreshVsPerf.R: use measure names for annotating the plots).
For the custom measure credit.costs calling get (in l. 99) causes the error. Apparently, when building the tutorial, credit.costs is not in the environment where get is looking.

Unfortunately, at the moment I can't reproduce the error itself.

@berndbischl
Copy link
Contributor

Who wrote that code there? I mean using a "get" is like saying "Please R, hurt me, now".
Why is that needed?

@jakob-r
Copy link
Contributor Author

jakob-r commented Jul 2, 2015

Please discuss what is broken not because of the directory change in another thread.

@berndbischl
Copy link
Contributor

Yes, we should keep issues separate. But I guess this might also be something rather for email. Let me just say one thing here, which I will repeat again in an email. Stuff like get() CANNOT be used, expect it is unavoidable. We need a proper programming style, somebody cannot write code ala "well it works on my machine, here, now".

@zmjones
Copy link
Contributor

zmjones commented Jul 2, 2015

I think that maybe was the commit that lars merged because he thought it was only the 50 minute error? You should revert that commit though!

@larskotthoff
Copy link
Contributor

Ok, all of that should be fixed now. I'll wait until after useR to reinstate Jakob's changes :)

@larskotthoff
Copy link
Contributor

I will do this now.

larskotthoff pushed a commit that referenced this issue Jul 3, 2015
larskotthoff pushed a commit that referenced this issue Jul 3, 2015
larskotthoff pushed a commit that referenced this issue Jul 3, 2015
@larskotthoff
Copy link
Contributor

Done.

@schiffner
Copy link
Contributor

Thanks, Lars.
I also did this:

9e7f1b2

mlr-org/mlr@86d6a4d

I hope we got everything now. :)

@larskotthoff
Copy link
Contributor

Thanks!

schiffner added a commit that referenced this issue Jul 6, 2015
larskotthoff pushed a commit that referenced this issue Feb 12, 2018
* travis button in readme

* Update README.md

* didn't see it there

* Put some links here [ci skip]

* Update paths (#2) in master Readme [ci skip]

* revert tutorial links for now

* tutorial links

* update 'handling of spatial data' with updated approach in mlr

* fix recent travis issue

`Sonar_example` again changed to `Sonar-Example` in recent mlr commit. Probably related to new generation of data sets

* Update nested_resampling.Rmd

* Update benchmark_experiments.Rmd

* reflect changes to generatePartialDependenceData and removal of fanova

* merge upstream

* Remove devel/ from PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants