-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#42 break up tuning into multiple sections WIP #43
Conversation
The Travis failure doesn't look related to my edits - any ideas? |
there was a renaming problem in the tutorial. can you rebase pls and check wether it works now? |
now i am getting this weird unload error with digest and pander. i tried to fix this. we will fix this later |
@berndbischl done |
This looks actually very nice, I really like your explanations and the colorful plots :-) Nevertheless, I have some (minor) suggestions for improvement. Let's start with the tune.Rmd (the one for the basic section):
I suggest to rewrite it to "We could also define a continuous search space (using
Now, let's have a look at learning_curve.Rmd and hyperpar_tuning_effects.Rmd:
|
Thanks @kerschke! I'll work on the above. |
Feedback is integrated with 2 slight exceptions: I still think we should say optimization algorithm (especially since the docs mention algo) so I added a note in parentheses for both the tutorials. I also didn't find a copy-pasta error, but I tweaked some of the language in any case. The Travis issue looks like a naming error in |
Looks like @zmjones fixed the Travis error with |
I'm also ok with optimization algorithm. Thank you very much for all the work you put into this and sorry that I haven't gotten around to look at your PR sooner. Will do this tomorrow at the latest. |
Ok, just read it now. I like it very much. |
irace
to advanced sectionThis is currently a WIP. I have rewritten @schiffner 's excellent work on the tuning section so that the "basic" stuff is in the basic section with more detail and hopefully understandable even by a beginner to mlr. You will notice several FIXMEs as I am awaiting my GSoC PR on mlr as well as deciding how we want to build out the "advanced" tuning tutorials as they are quite complicated and will need a lot of additional detail.