fix pretty.names = FALSE in plotThreshVsPerf (#1168)

fix for #1167
mlr-org · Aug 18, 2016 · 2e52b97 · 2e52b97
1 parent 1525ff0
commit 2e52b97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/R/generateThreshVsPerf.R b/R/generateThreshVsPerf.R
@@ -155,6 +155,8 @@ plotThreshVsPerf = function(obj, measures = obj$measures,
   if (pretty.names) {
     mnames = replaceDupeMeasureNames(measures, "name")
     colnames(obj$data) = mapValues(colnames(obj$data), names(measures), mnames)
+  } else {
+    mnames = names(measures)
   }
 
   data = setDF(melt(as.data.table(obj$data), measure.vars = mnames, variable.name = "measure", value.name = "performance", id.vars = id.vars))

diff --git a/tests/testthat/test_base_generateThreshVsPerf.R b/tests/testthat/test_base_generateThreshVsPerf.R
@@ -24,7 +24,7 @@ test_that("generateThreshVsPerfData", {
   rdesc = makeResampleDesc("CV", iters = 2L)
   r = resample(lrn, binaryclass.task, rdesc)
   pvs = generateThreshVsPerfData(r, list(tpr, fpr))
-  plotThreshVsPerf(pvs)
+  plotThreshVsPerf(pvs, pretty.names = FALSE)
   ggsave(path)
   doc = XML::xmlParse(path)
   #expect_that(length(XML::getNodeSet(doc, grey.xpath, ns.svg)), equals(length(pvs$measures)))