Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conf matrix and ROCMeasures #48

Merged
merged 3 commits into from
Aug 31, 2016
Merged

Conf matrix and ROCMeasures #48

merged 3 commits into from
Aug 31, 2016

Conversation

ja-thomas
Copy link
Contributor

Documentation for two new functions in mlr calculateROCMeasures and calculateConfusionMatrix.

Do not merge this before PR #1113 and #1071 in mlr are merged.

Feedback appreciated :)

@ja-thomas ja-thomas changed the title Conf matrix [DO NOT MERGE] Conf matrix and ROCMeasures Aug 14, 2016
@ja-thomas
Copy link
Contributor Author

Both above mentioned PRs are now merged. Should hopefully be ready to merge after travis passes and somebody has proofread it.

Thanks

@schiffner
Copy link
Contributor

Will do, thx!

@schiffner
Copy link
Contributor

schiffner commented Aug 31, 2016

Sorry for taking this long and thank you for writing this!

I went into your branch, did a little cleanup and tweaked the language a little.
The only small addition I made is to show how to get the relative values normalized in one direction from the ConfusionMatrix object (i.e. $relative.col and $relative.row, because that's something that I would want to know and use).
Ok?

The link from the performance page to the confusion matrix section was broken. How to do this correctly is not explained very clearly in the mkdocs documentation. I added a short explanation to the tutorial README, so in the future we know...

@ja-thomas
Copy link
Contributor Author

perfect, thanks :)

@schiffner schiffner merged commit 09f0053 into gh-pages Aug 31, 2016
@schiffner
Copy link
Contributor

Ok, merging. And also thanks :)

@schiffner schiffner deleted the conf_matrix branch September 1, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants