Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ROC matrix #1113

Merged
merged 13 commits into from
Aug 13, 2016
Merged

Get ROC matrix #1113

merged 13 commits into from
Aug 13, 2016

Conversation

ja-thomas
Copy link
Contributor

nicer printer for the ROC matrix.

> print(x)
    predicted
true M         R                            
   M 14        15        TPR: 0.48 FNR: 0.52
   R 4         42        FPR: 0.09 TNR: 0.91
     PPV: 0.60 FOR: 0.26 LRP: 5.55 ACC: 0.75
     FDR: 0.40 NPV: 0.74 LRM: 0.57 DOR: 9.80


Abbreviations:
TPR - True positive rate (Sensisivity, Recall)
FPR - False positve rate (Fall-out)
FNR - False negative rate (Miss rate)
TNR - True negative rate (Specifity)
PPV - Positive predictive value (Precision)
FOR - False omission rate
LRP - Positive likelihood ratio (LR+)
ACC - Accuracy
LRM - Nevative likelihood ratio (LR-)
DOR - Diagnostic odds ratio

@berndbischl
Copy link
Sponsor Member

  1. pls doc
  2. the printer should have a flag to display the abbrevs
  3. getROCMatrix with "M"
  4. does relative = FALSE even make sense? remove?

@bhvieira
Copy link
Contributor

Is ROC matrix a good name though?

@berndbischl
Copy link
Sponsor Member

Is ROC matrix a good name though?

well it was what came to our mind first.
it is basically this here
https://en.wikipedia.org/wiki/Receiver_operating_characteristic

better suggestion welcome

@PhilippPro
Copy link
Member

confusion matrix?

at first glance roc matrix seemed to me a bit confusing (I thought about a matrix with the values of the ROC Curve)

@ja-thomas
Copy link
Contributor Author

there is already getConfusionMatrix, which is also possible for multiclass problems.

Maybe it makes sense to combine both functions?

@berndbischl
Copy link
Sponsor Member

confusion matrix we already have.
calcROCMeasures?

reasons:

  • it is no getter
  • it returns no matrix
  • clearer

we should then maybe also rename getConfMarix --> calcConfusionMatrix

@berndbischl
Copy link
Sponsor Member

and deprecate getConfMatrix

@berndbischl
Copy link
Sponsor Member

Maybe it makes sense to combine both functions?

hmmm. maybe. yes. probably

@ja-thomas
Copy link
Contributor Author

should hopefully be good now. The name is calculateROCMeasures

@berndbischl
Copy link
Sponsor Member

  1. pls rename als measures to lower case

  2. pls doc the return type in a complete fashion. and conf.matrix not confMatrix.

  3. for all defaults add them to the docs

  4. use families "roc" and "performance"

@ja-thomas
Copy link
Contributor Author

so the renaming for the measures is kind of annoying,

for example False Omission Rate -> for. I can't think of a diffferent three letter abbreviation. Everything else should be fixed.

@berndbischl
Copy link
Sponsor Member

@ja-thomas
i guess you need to fix this

@berndbischl berndbischl merged commit d444a3c into master Aug 13, 2016
@berndbischl berndbischl deleted the getROCmatrix branch August 15, 2016 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants