-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate pdf version of tutorial #58
Conversation
Build broken because of other issues. Wait with merge until fixed. |
I am honestly impressed by the numbers of pages and that it looks so good in most parts but there are some issues still left
Personally as I mentioned before. I would try do drop the "Integrated *" parts in the pdf version because
|
For me they work, the links to rdocumentation as well as links to papers and other websites. |
Dropping the integrated* parts would cause some broken links throughout. I don't see the argument for them being outdated quickly as we regenerate the PDF every time the tutorial is built. |
Headers now added, see new attachment -- they overlap on some pages, but can be customised in the usual LaTeX way. |
Just take everybody how did a commit on the repo?
Thanks again ! |
I haven't found out yet where/how this is happening, but none of the figures is where it is supposed to be. For example on p. 24 there should be a scatterplot instead of the threshold-vs-perf plot and p. 35 shows ROC curves instead of the learner-prediction plots. |
Argh, the filenames generated by knitr are not unique. I'll fix that. |
|
Thanks very much.
I think this is @PhilippPro (?) |
Regarding the author list: Did you also look in the old mlr gh-pages branch?
|
yes (twice)
it is either P Probst, who must be added. Or somebody irrelevant.
Did they do relevant, larger changes or just mini commits? |
authors: giuseppe did the classifier calibration stuff. |
WRT numbering and structure: thx much better now. |
Zach wrote this (https://github.com/mlr-org/mlr-tutorial/commits/gh-pages/src/classifier_calibration.Rmd) |
studerus: no |
This is actually easily done by setting the internal drawing size of the graphic device a bit smaller. opts_chunk$set(
fig.width = 8,
fig.height = 5
) |
|
IcedragonP = Philipp Probst So you can delete IcedragonP. |
Thx very much, Lars!!! Re: Figures
So my proposal is
|
Ok, sounds good. There are many imperfections anyway and we can't fix all of them now. I've fixed the author list. |
Unfortunately... But I fixed most of the plots now. |
We need to add Janek to the author list. |
Small issues:
|
What's the verdict on this? Fixing all the minor issues will take a lot of effort and time. I vote to merge this now so that we have a reasonable, but not perfect PDF, and improve this later. |
I'm also pro merging. |
then do it. |
Ok, why didn't this squash the commits when I merged? It seems to be set up to do that? |
the settings now seem to allow squashing merges and normal, multi-commit merges. |
Changed build to generate PDF version of tutorial. This is generating the tutorial with external PDF figures, collating the markdown files, fixing the internal links, adding a title, converting to PDF. Then generating the tutorial with embedded SVG figures. PDF version will be committed with the rest of the tutorial.
This is generating the entire tutorial twice, but I'm not sure we care about it since it happens on Travis anyway.
Fixes #50.
mlr-tutorial.pdf