Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Aggregation of probabilities #2579

Merged
merged 10 commits into from May 20, 2019

Conversation

Projects
None yet
2 participants
@mllg
Copy link
Member

commented Apr 30, 2019

1st attempt to fix #2578

mllg and others added some commits Apr 30, 2019

@pat-s
Copy link
Member

left a comment

Could you also add an entry to NEWS.md?

DESCRIPTION Outdated
@@ -261,9 +261,6 @@ Suggests:
VignetteBuilder:
knitr
Remotes:
berndbischl/BBmisc,

This comment has been minimized.

Copy link
@pat-s

pat-s May 14, 2019

Member

Was this change on purpose or bc the Travis build failed back then?

This comment has been minimized.

Copy link
@mllg

mllg May 14, 2019

Author Member

Is there a reason why why install the devel version? If yes, we need to upload BBmisc before the next CRAN release. Otherwise it would be best to use the exact same version CRAN uses.

This comment has been minimized.

Copy link
@pat-s

pat-s May 14, 2019

Member

AFAIK there was but probably all problems have been fixed? I released v2.14.0 ofc without the Remotes Field and everything seems to be fine. So yes, I guess we can drop these requirements.

pat-s added some commits May 18, 2019

@pat-s

pat-s approved these changes May 19, 2019

@pat-s

This comment has been minimized.

Copy link
Member

commented May 19, 2019

@mllg I added NEWS, please merge if you approve.

@pat-s pat-s changed the title Fix new data.table Bugfix: Aggregation of probabilities May 20, 2019

@mllg mllg merged commit b7c0279 into master May 20, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@mllg

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

Perfect, thanks!

@mllg mllg deleted the rbind_data_table branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.