Enable FDboost tests again #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfistfl Do you have time for this in the near future? If not, I might need to remove the FDboost learner again if we can't test it. |
|
Starting to remove the FBboost learner then in the near future, I do not have capacities/knowledge to maintain it. |
|
Sorry for the long silence, will let you know by tonight what to do with this |
|
Seems to be an issue in FDboost, see boost-R/FDboost#17 |
|
Thanks Flo. Let's see if someone replies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the package is back on CRAN.
@pfistfl
It looks like we have some true positive test failures for the FDboost tests now: https://github.com/mlr-org/mlr/runs/832076608?check_suite_focus=true#step:17:305
Would be great if you could have a look.
fixes #2758