Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add par.set to RemoveConstantFeaturesWrapper() #2806

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Add par.set to RemoveConstantFeaturesWrapper() #2806

merged 3 commits into from
Feb 19, 2021

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Feb 15, 2021

fixes #2516

Due to a name clash with popular base learner hyperpars tol, the wrapper hyperpar tol was renamed to wrap.tol and backward comp for tol was added.

library(mlr)
#> Loading required package: ParamHelpers
#> Warning message: 'mlr' is in 'maintenance-only' mode since July 2019.
#> Future development will only happen in 'mlr3'
#> (<https://mlr3.mlr-org.com>). Due to the focus on 'mlr3' there might be
#> uncaught bugs meanwhile in {mlr} - please consider switching.
lrn <- makeLearner("classif.ksvm", C = 123)
lrn <- makeRemoveConstantFeaturesWrapper(lrn, perc = 5)
p <- getHyperPars(lrn)
print(p)
#> $fit
#> [1] FALSE
#> 
#> $C
#> [1] 123
#> 
#> $perc
#> [1] 5
#> 
#> $dont.rm
#> character(0)
#> 
#> $na.ignore
#> [1] FALSE
#> 
#> $wrap.tol
#> [1] 1.490116e-08

Created on 2021-02-15 by the reprex package (v1.0.0)

@pat-s pat-s merged commit 8758fb3 into main Feb 19, 2021
@pat-s pat-s deleted the f-2516 branch February 19, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential bug in WrappedModel
1 participant