Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/inner valid #1020

Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

Feat/inner valid #1020

wants to merge 78 commits into from

Conversation

sebffischer
Copy link
Sponsor Member

@sebffischer sebffischer commented Apr 25, 2024 •
edited

TODOs:

  • paradox release

Check that (failed after last revdepcheck):

  • mlr3fairness branch works with this mlr3 branch (there was a bug in fairness)
  • mlr3mbochecks pass releasing mlr3
  • mlr3tuning branch works with this mlr3 branch (example from additional measures callback used test rows + AutoTuner properties)
  • mlr3fselect branch works with this mlr3 branch (properties of fselector)

be-marc and others added 30 commits December 7, 2023 15:23
@be-marc
refactor: remove task prototype when resample
2c77828
@be-marc
refactor: add option to store prototype
2164d4d
@be-marc
fix: braket
21ed459
@be-marc
refactor: null
cef8117
@be-marc
fix: browser
48f40fa
@sebffischer
keep prototypes in state when store_models is TRUE
1c027cd
@sebffischer
feat(Learner): uses_test_set active binding
8788355
@sebffischer
...
b29d558
@sebffischer
...
c2726c9
@sebffischer
...
73247c4
@sebffischer
...
ddfa67d
@sebffischer
Update R/Learner.R
dd65441
@sebffischer
Update R/Learner.R
1dd12cc
@sebffischer
...
3d06488
@sebffischer
allow cbinding test rows to task
c58da30
@sebffischer
add test
02fa3dd
@sebffischer
allow to cbind test rows
3aabaef
@sebffischer
Update NEWS.md
5b983ee
@sebffischer
avoid unnecessary sort
9e8ae85
@sebffischer
work on test and holdout tas
9a0e954
@sebffischer
Merge branch 'main' into feat/train-predict
379e2f2
@sebffischer
BREAKING_CHANGE: test/holdout task replace test/holdout roles
4cb8b8e
@sebffischer
fix some issues regarding test task
448296d
@sebffischer
better news
343f475
@sebffischer
pipelines dependency
944adfc
@sebffischer
uber hack for revdepcheck
bdd54fb
@sebffischer
remove remotes
c465b7f
@sebffischer
optimization
29e21bd
@sebffischer
refactor: partition method is now called divide
1c06fb7
@sebffischer
comment hack
fe54dac
@sebffischer
Update tests/testthat/test_resample.R
0a913a1
@sebffischer
Merge branch 'main' into feat/inner_valid
04d7002
@sebffischer
pkgdown, paradox dep
bad573e
@sebffischer
correct paradox branch
4618ce8
@sebffischer
refactor, relax checks in valid task
620b8f6
@sebffischer
rename
00c8ba8
@sebffischer
fix bug introduced during renaming
7b95f0b
@sebffischer
fix bug in assert validate
7dc35dd
@sebffischer
coerce to int in classif.debug aggregator
c5614d9
@sebffischer
improve docs, comments
f728976
@sebffischer
address feedback from review
2560ffc
@sebffischer
disable internal tuning is handled by paradox
dae6f11
@sebffischer
add tuning assertion generic
5a19403
@sebffischer
Merge branch 'main' into feat/inner_valid
eeb5d19
@sebffischer
typo, document
f8d700f
@sebffischer
fix assert internal tuning for classif.debug
de55b76
@sebffischer
default method for assert internal tuning
c4b1e6e
@sebffischer
this anticipates incompatibility with pipelines
ad6317b
@sebffischer
dont remove internal valid task
3b3f1df
@sebffischer
better error message
fe027e3
@sebffischer
always store internal valid task hash
94d0bc2
@sebffischer
more tests
19483a7
@sebffischer
dont save internal valid task ids
4206974
@sebffischer
...
579436c
@sebffischer
...
d4e5286
@sebffischer
...
c7c423e
@sebffischer
cleanup
970ca6b
@sebffischer
only use existing predict sets
a47e045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebffischer @be-marc