Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Backends #65

Merged
merged 5 commits into from Nov 12, 2018
Merged

More Backends #65

merged 5 commits into from Nov 12, 2018

Conversation

mllg
Copy link
Sponsor Member

@mllg mllg commented Nov 12, 2018

  • Includes a DataBackend for Matrix
  • Backend construction helper: as_data_backend()
  • New field "formats" for DataBackend which describes the possible output formats
  • We need to define how auto-conversion of formats can be handled

Matrix backend is still experimental, we need to progress with the pipelines before I can finalize this.

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #65 into master will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   90.64%   90.67%   +0.03%     
==========================================
  Files          60       61       +1     
  Lines        1293     1341      +48     
==========================================
+ Hits         1172     1216      +44     
- Misses        121      125       +4
Impacted Files Coverage Δ
R/TaskClassif.R 86.95% <ø> (ø) ⬆️
R/mlr_tasks.R 90.9% <ø> (-9.1%) ⬇️
R/TaskRegr.R 100% <ø> (ø) ⬆️
R/DataBackend.R 100% <100%> (ø) ⬆️
R/DataBackendDataTable.R 100% <100%> (ø) ⬆️
R/Task.R 87.01% <100%> (ø) ⬆️
R/helper_misc.R 94.73% <100%> (+0.61%) ⬆️
R/DataBackendOverwrite.R 95.65% <50%> (+0.19%) ⬆️
R/DataBackendRbind.R 91.66% <50%> (+0.36%) ⬆️
R/DataBackendCbind.R 94.73% <50%> (+0.29%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a859b...b729ab2. Read the comment docs.

@mllg mllg merged commit cbc5946 into master Nov 12, 2018
@mllg mllg deleted the databackend_factory branch November 12, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant